-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E tests to workflow #657
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for tackling this! that must have been a lot of work. Having e2e tests running on the CI will add more constraints but hopefully it will help us keep a higher level of quality. 😎
I think it might be good to add a npm run e2e
script (if it's not already there) and mention that having it pass is mandatory in the contributing guidelines.
Other than that I had several questions on your changes, see below!
$cookie.find('button').eq(0).click() | ||
cy.scrollTo('top') | ||
} | ||
Cypress.on('uncaught:exception', (err) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping we could have a central place to put Cypress custom commands, instead of having to duplicate these in the different apps; or maybe from here you could import the commands from the datahub-e2e app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find a simple and clean way for the moment so I didn't implement it by now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be done later, no worries
🔧 E2E tests now works with Github actions.
Barbie Inc.
💢 Known problems