Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [Datahub]: Do not point to future web component version #673

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Nov 7, 2023

PR sets same env.version for prod as for dev as prod env is also used for latest builds (and not only local dev). This should fix the datahub latest build to point to the main web component dist branch instead of a version that does not exist yet.

this should fix the datahub latest build to point to the main web component dist branch instead of a version that does not exist yet
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 87.443% (+5.2%) from 82.269%
when pulling d61eae3 on fix-wc-version
into 499c9ac on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tkohr tkohr added the bug Something isn't working label Nov 7, 2023
@tkohr tkohr merged commit d42c29a into main Nov 7, 2023
6 checks passed
@tkohr tkohr deleted the fix-wc-version branch November 7, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants