Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Fix display of news org thumbnail #711

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Dec 4, 2023

PR display news org thumbnail as contain, which should give better results here, especially with wide logos:

before:
news_logo

after:
news_logo_contain

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Affected libs: ui-search, feature-search, feature-router, feature-map, feature-dataviz, feature-record,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! no change to when no logo is available right?

@tkohr
Copy link
Collaborator Author

tkohr commented Dec 4, 2023

Right, in this case the record-preview-feed.component displays a mat-icon here.

@tkohr tkohr merged commit f46b998 into main Dec 4, 2023
7 checks passed
@tkohr tkohr deleted the news-org-thumbnail branch December 4, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants