Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at fixing flaky E2E tests #730

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Attempt at fixing flaky E2E tests #730

merged 4 commits into from
Dec 15, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Dec 13, 2023 •
edited
Loading

  • Download file on click: the targeted file is now mocked so we won't be relying on an actual third-party endpoint
  • WMS query params order was changed since the update of OpenLayers in Fix(DH): Center bbox extent with different coordinate reference system #698, this PR fixes the interception pattern
  • Sorting by date changes the results order: this test was failing due to a race condition, fixed in this PR
  • Improved the login command to avoid race conditions (now everything coming after it will be chained instead of run in parallel)

I also simplified the JSON fixture which was quite big (hence the big diff)

@jahow
feat(e2e): mock downloaded csv file, check final size in test
af19b1a 
This avoid relying on a third-party website
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@jahow jahow force-pushed the fix-e2e-datahub-download-test branch from 491cbe9 to 1c892f0 Compare December 13, 2023 14:37
@jahow
fix(e2e): improve login command & remove useless clearCookies
98d3856 
The login command now returns a Cypress chain; this means that everything after
it will be executed after it's done; this will prevent race conditions

Cookies are cleaned between every run.
@jahow jahow force-pushed the fix-e2e-datahub-download-test branch from 2ec4def to 98d3856 Compare December 13, 2023 15:50
tkohr
tkohr approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the various tweaks @jahow!

apps/datahub-e2e/src/e2e/datasets.cy.ts Show resolved Hide resolved
apps/datahub-e2e/src/e2e/datasets.cy.ts Show resolved Hide resolved
@jahow jahow merged commit beedacc into main Dec 15, 2023
6 checks passed
@jahow jahow deleted the fix-e2e-datahub-download-test branch December 15, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jahow @tkohr