Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Fix : Improve linkify REGEX #754

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 8, 2024

This PR improves the Linkify directive's REGEX to avoid including end parenthesis.

--> End parenthesis used to be detected as part of the URLS, ex :

image-2024-01-08-12-04-25-004

--> Now they're not :

image

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier marked this pull request as draft January 8, 2024 16:20
@cmoinier cmoinier marked this pull request as ready for review January 9, 2024 08:10
@coveralls
Copy link

Coverage Status

coverage: 86.421% (+0.03%) from 86.396%
when pulling 4c0daff on DH/fix-link-detection
into 173df65 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done, regexes are tricky :)

@cmoinier cmoinier merged commit 513ce2f into main Jan 9, 2024
10 of 12 checks passed
@cmoinier cmoinier deleted the DH/fix-link-detection branch January 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants