-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datahub][Redesign] Details exapandable panel #769
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just looked at the screen shot, it looks great 👌
I see some icons on the mockups you might have forgotten them 🙃
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proper layout @cmoinier ! I just left a comment about an uncertainty regarding the themes.
libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts
Outdated
Show resolved
Hide resolved
I added the icons & removed the grey background and left margin, to match the mockups. |
libs/ui/elements/src/lib/metadata-info/metadata-info.component.html
Outdated
Show resolved
Hide resolved
ab66332
to
f4cf520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adaptions @cmoinier, looks really clean now 🙂
1b51dcc
to
ff66000
Compare
This PR applies the redesign of the header section, namely :
To do :
This is NOT COVERED :
To test
Dataset
/dataset/01491630-78ce-49f3-b479-4b30dabc4c69
has all of the needed parameters of the design.Screenshot