Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub][Redesign] Details exapandable panel #769

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 15, 2024

This PR applies the redesign of the header section, namely :

  • Change the title of the "details" panel to "technical information"
  • Show the last metadata update time
  • Show the name of the source catalog
  • Show the unique dataset identifier
  • Show categories/themes
  • Show keywords

To do :

  • Use gn-ui-copy-button
  • Revert linkify button
  • Make themes not clickable
  • Do not split the themes

This is NOT COVERED :

  • Downloads count: this information is not yet available and might require a modification of the backend

To test

Dataset /dataset/01491630-78ce-49f3-b479-4b30dabc4c69 has all of the needed parameters of the design.

Screenshot

image

Copy link
Contributor

github-actions bot commented Jan 15, 2024

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 86.322% (-0.06%) from 86.378%
when pulling 534c679 on DH/redesign-details-panel
into 55bb5e1 on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just looked at the screen shot, it looks great 👌
I see some icons on the mockups you might have forgotten them 🙃
Thanks

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proper layout @cmoinier ! I just left a comment about an uncertainty regarding the themes.

@cmoinier
Copy link
Collaborator Author

I added the icons & removed the grey background and left margin, to match the mockups.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions @cmoinier, looks really clean now 🙂

@cmoinier cmoinier merged commit bea8410 into main Jan 22, 2024
8 checks passed
@cmoinier cmoinier deleted the DH/redesign-details-panel branch January 22, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants