Datahub: Get logoUrl from group as fallback #821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets the
logoUrl
for a record from the publishinggroup
as a fallback iflogoUrl
is present in the record metadata andlogoUrl
can be determined by the organization - group matching based onname
andemails
.It might be worth noting that this also impacts the thumbnail in the search preview and the contact block on the record page, where the organization logo already seems to be used as a fallback before using the placeholder. As this PR will help to find organization/group logos in more cases, the placeholder will likely be less used in these two places as well.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.