Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Get logoUrl from group as fallback #821

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Datahub: Get logoUrl from group as fallback #821

merged 2 commits into from
Mar 14, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Mar 13, 2024

Description

This PR gets the logoUrl for a record from the publishing group as a fallback if

  • no logoUrl is present in the record metadata and
  • no logoUrl can be determined by the organization - group matching based on name and emails.

It might be worth noting that this also impacts the thumbnail in the search preview and the contact block on the record page, where the organization logo already seems to be used as a fallback before using the placeholder. As this PR will help to find organization/group logos in more cases, the placeholder will likely be less used in these two places as well.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Co-authored-by: Olivia Guyot <olivia.guyot@camptocamp.com>
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-fixtures, api-metadata-converter, feature-editor, ui-search, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 83.312% (-0.03%) from 83.342%
when pulling 6bb6ab1 on group-logos
into 1189d39 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested and it works really well!! I made a suggestion to improve the code :)

@tkohr tkohr merged commit ecc0ab6 into main Mar 14, 2024
9 checks passed
@tkohr tkohr deleted the group-logos branch March 14, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants