Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Change typos to Public Sans semi-bold (title) and Source Sans (text) #828

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ronitjadhav
Copy link
Collaborator

Description

This PR introduces a change of title font to 'Public Sans Semi-Bold' and the main font to 'Source Sans'.

Title font: https://fonts.google.com/specimen/Public+Sans?query=public+sans
Main font: https://fonts.google.com/specimen/Source+Sans+3?query=source+sans

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

@ronitjadhav ronitjadhav requested a review from jahow March 20, 2024 11:00
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@ronitjadhav ronitjadhav requested a review from tkohr March 20, 2024 11:00
@coveralls
Copy link

coveralls commented Mar 20, 2024

Coverage Status

coverage: 86.427% (+4.2%) from 82.262%
when pulling fd0c430 on DH-Update-Font-Style
into 463b60b on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ronitjadhav ! I've added a commit to make sure the font-weight 600 from the mockups is applied. Let me know if you agree with this change. From my side feel free to merge.

@tkohr tkohr mentioned this pull request Mar 20, 2024
7 tasks
@ronitjadhav
Copy link
Collaborator Author

@tkohr Thank you for the update. I will proceed with the merge.

@ronitjadhav ronitjadhav merged commit 54d2ced into main Mar 20, 2024
9 checks passed
@ronitjadhav ronitjadhav deleted the DH-Update-Font-Style branch March 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants