Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Update Default Main and Title Fonts to Rubik and Readex Pro #834

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

ronitjadhav
Copy link
Collaborator

Description

This PR updates the default main and title fonts used in the Datahub application. The changes are as follows:

  • The main font has been changed to 'Rubik'.
  • The title font has been changed to 'Readex Pro'.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@ronitjadhav ronitjadhav requested a review from jahow March 25, 2024 10:20
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Mar 25, 2024

Coverage Status

coverage: 86.337% (+3.0%) from 83.385%
when pulling 05f238b on DH-Default-Font-Update
into c319ec6 on main.

Copy link
Contributor

github-actions bot commented Mar 25, 2024

📷 Screenshots are here!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ronitjadhav ronitjadhav merged commit 7639a97 into main Mar 25, 2024
9 checks passed
@ronitjadhav ronitjadhav deleted the DH-Default-Font-Update branch March 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants