Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Editor: implement notifications when saving a record #855

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Apr 15, 2024

Description

This PR introduces a notifications system which is used in the Metadata Editor to:

  • show an error if a record couldn't be saved
  • show an error if a record couldn't be opened
  • show a success after a record is saved

Architectural changes

The following library was introduced: feature-notifications. It contains a service for showing and closing notifications, as well as a container component to show notifications on a page.

I also introduced generic gn-ui-link and gn-ui-link-external CSS classes in the common tailwind stylesheet; this could be used later on to replace most links that were done slightly differently each time.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-fixtures, api-metadata-converter, feature-editor, ui-search, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, util-i18n, util-app-config,
Affected apps: datafeeder, datahub, demo, map-viewer, metadata-converter, metadata-editor, search, webcomponents,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Apr 15, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Apr 15, 2024

Coverage Status

coverage: 83.789% (+2.1%) from 81.72%
when pulling f385cf3 on me-implement-notifications
into b46332e on main.

Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real nice!
Unfortunately, I could only look at the storybook. I can't fully test it until the support docker composition works again on my machine.

EDit: I was finally able to try out, working great!

@jahow jahow force-pushed the me-implement-notifications branch from 38fd2cd to f385cf3 Compare April 19, 2024 09:53
@jahow jahow merged commit 6083baa into main Apr 19, 2024
7 checks passed
@jahow jahow deleted the me-implement-notifications branch April 19, 2024 10:03
@jahow
Copy link
Collaborator Author

jahow commented Apr 19, 2024

Aand it's in 🙂 thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants