-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Editor: implement notifications when saving a record #855
Conversation
Affected libs:
|
📷 Screenshots are here! |
libs/ui/elements/src/lib/notification/notification.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking real nice!
Unfortunately, I could only look at the storybook. I can't fully test it until the support docker composition works again on my machine.
EDit: I was finally able to try out, working great!
for load record error and save record error added a saveSuccess$ observable on the facade
flex-shrink and flex-grow were still working but are not part of the TW api anymore. https://tailwindcss.com/docs/flex-grow https://tailwindcss.com/docs/flex-shrink
for homogeneity
38fd2cd
to
f385cf3
Compare
Aand it's in 🙂 thanks for the review! |
Description
This PR introduces a notifications system which is used in the Metadata Editor to:
Architectural changes
The following library was introduced:
feature-notifications
. It contains a service for showing and closing notifications, as well as a container component to show notifications on a page.I also introduced generic
gn-ui-link
andgn-ui-link-external
CSS classes in the common tailwind stylesheet; this could be used later on to replace most links that were done slightly differently each time.Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label