Datahub - add info when metadata has no online ressource

[rcaplier]

Description

This PR introduces a new warning block for when a record dataset has neither API, download or other links to display.

Screenshots

Quality Assurance Checklist

• Commit history is devoid of any merge commits and readable to facilitate reviews
• If new logic ⚙️ is introduced: unit tests were added
• If new user stories 🤏 are introduced: E2E tests were added
• If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
• If breaking changes 🪚 are introduced: add the breaking change label
• If bugs 🐞 are fixed: add the backport <release branch> label
• The documentation website 📚 has received the love it deserves

---

This work is sponsored by Swisstopo geocat.

[github-actions]

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-elements, feature-notifications, feature-catalog, feature-editor, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder,

• 🚀 Build and deploy storybook and demo on GitHub Pages
• 📦 Build and push affected docker images

[coveralls]

coverage: 84.292% (-0.2%) from 84.492%
when pulling 48fd10a on dh-add-info-when-metadata-has-no-online-ressource
into cc25794 on main.

[github-actions]

📷 Screenshots are here!

[cmoinier]

Thanks for this feature @rcaplier ! 😃 It looks really good already. Two remarks/questions under here + would be nice to add e2e testing (difficult to do for other errors, but for the absence of links, you would just have to point to a dataset where you would have removed all the links, perhaps there is already an existing one that you used for this PR? LMK if you need help with that).

[rcaplier]

Thanks for this feature @rcaplier ! 😃 It looks really good already. Two remarks/questions under here + would be nice to add e2e testing (difficult to do for other errors, but for the absence of links, you would just have to point to a dataset where you would have removed all the links, perhaps there is already an existing one that you used for this PR? LMK if you need help with that).

Thank you. I've had to make a new dataset with no link in it to see the result. Do I have to make another dump so we have it and point to it in the e2e tests ? Or maybe I can cheat in the e2e by simulating a record with no link ? 😎

[cmoinier]

Thanks for this feature @rcaplier ! 😃 It looks really good already. Two remarks/questions under here + would be nice to add e2e testing (difficult to do for other errors, but for the absence of links, you would just have to point to a dataset where you would have removed all the links, perhaps there is already an existing one that you used for this PR? LMK if you need help with that).

Thank you. I've had to make a new dataset with no link in it to see the result. Do I have to make another dump so we have it and point to it in the e2e tests ? Or maybe I can cheat in the e2e by simulating a record with no link ? 😎

Yes you can use that one and make a dump! I think simulating a record without any links would be too time consuming, I would use the one you got 😉

[jahow]

Just a general comment, could we maybe be more specific and instead of "noLink" use "recordHasNoLink"? E.g. search.error.recordHasNoLink, ErrorType.RECORD_HAS_NO_LINK, etc.

[cmoinier]

Thanks for the last changes, LGTM 👌