-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] : Handle non geospatial ogc services #889
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cmoinier, this works really well! I'm just noticing that the map
tab is still clickable when there is a problem with the OGC API calls. This can easily be reproduced in dev by not using a CORS plugin in the browser. It's not directly related to this PR as it also causes an uncaught error on main
I think. I propose to take a look if you can solve it here, and otherwise we'll solve it in a separate PR. Note there is GSMEL-542 that seems related.
apps/datahub/src/app/record/record-metadata/record-metadata.component.ts
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/record/record-metadata/record-metadata.component.ts
Outdated
Show resolved
Hide resolved
ab83987
to
8a57ff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional fix @cmoinier, which works well on my side!
Do you think you could reflect your changes for this in the unit tests of the map-utils.service.ts
, data.service.ts
and mdview.facade.ts
by adapting fixtures for the fixed case and adding tests for new methods?
apps/datahub/src/app/record/record-metadata/record-metadata.component.ts
Show resolved
Hide resolved
b5f3a28
to
28e7a73
Compare
28e7a73
to
d89a1b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the added tests and the falsy
start 🤩
Description
This PR fixes a bug found in MEL datahub, where the OGC API services that are non geospatial were wrongfully displayed on the map component.
In this PR, we test if one of the features of the service has or not a geometry. Depending on that, if it's the only service, the map will or will not be displayed. If there are other services viewable in the map, the OGC service will be removed from the dropdown list if not geospatial.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.