-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDITOR - Record field: graphic overview #909
Conversation
Affected libs:
|
648d4b8
to
b41e624
Compare
📷 Screenshots are here! |
b3c6e02
to
9b596c5
Compare
9b596c5
to
47b30b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, not tested.
Although, there is some added complexity which I don't understand.
And here too, the name of the PR should not reference our internal Jira tickets.
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/data-access/gn4/src/openapi/model/metadataResource.api.model.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
@rcaplier could you resolve the conflicts on this PR, so we can do a final review before merging? Thanks! |
The final review will come when I will finish it. Like I said in dailies, I still have to adapt the component regarding the version of geonetwork. I still don't know if I have to hide it disable it. Does this need design @jahow ? Plus, I have to readd the But thanks for the reminder |
337dee9
to
3a6c33f
Compare
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/overview-upload/overview-upload.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it this time. The alternative text is not being saved, not on draft and not on record.
Tell me if you need to have a look on my machine.
92d639a
to
5d22074
Compare
5e3b390
to
08c5483
Compare
08c5483
to
2a38a00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, working as it should now!
Description
This PR introduces the graphical overview component. Now editor allows to edit the overview of the metadata.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label**This work is sponsored by **.