Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset page] : Share features for tables and maps #921

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jun 28, 2024

Description

This PR introduces the share and embedding functionalities to the table and map views of the preview. It also adds a new web component for the map view.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

@cmoinier cmoinier force-pushed the share-integrate-maps-tables branch from c7f2d60 to bb2314a Compare June 28, 2024 12:47
@cmoinier cmoinier changed the title [Dataset page] : [Dataset page] : Share features for tables and maps Jun 28, 2024
Copy link
Contributor

github-actions bot commented Jun 28, 2024

Affected libs: feature-record, feature-router,
Affected apps: datahub, webcomponents, metadata-editor, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.647% (+3.5%) from 83.112%
when pulling bb2314a on share-integrate-maps-tables
into fe59f17 on main.

Copy link
Contributor

github-actions bot commented Jun 28, 2024

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 86.647% (+3.5%) from 83.112%
when pulling 0225bdf on share-integrate-maps-tables
into fe59f17 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice feature @cmoinier ! Looks mostly good to me, just left some comments inline.

Not sure if you've tested it locally, but if you want to do so, you can by:

  • setting a remote geonetwork4_api_url and uncommenting web_component_embedder_url = "/datahub/wc-embedder.html" in the default.toml
  • npx nx docker-build datahub
  • docker run -p 8082:80 geonetwork/geonetwork-ui-datahub:share-integrate-maps-tables

@jahow jahow added this to the 2.4.0 milestone Jul 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 86.23% (+3.1%) from 83.112%
when pulling 51db788 on share-integrate-maps-tables
into fe59f17 on main.

@cmoinier cmoinier requested a review from tkohr July 2, 2024 08:45
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmoinier !

As we discussed one last thing is to not display the share features when no links are present:

image

... and to comment the bootstrap as mentioned in line. Otherwise looks good to merge.

@coveralls
Copy link

coveralls commented Jul 15, 2024

Coverage Status

coverage: 86.23% (+4.9%) from 81.314%
when pulling 5bb338b on share-integrate-maps-tables
into 58b3c2e on main.

@cmoinier cmoinier force-pushed the share-integrate-maps-tables branch from c60bdbf to 5bb338b Compare July 15, 2024 08:35
@cmoinier cmoinier merged commit 71a43b3 into main Jul 15, 2024
9 checks passed
@cmoinier cmoinier deleted the share-integrate-maps-tables branch July 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants