-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset page] : Share features for tables and maps #921
Conversation
c7f2d60
to
bb2314a
Compare
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice feature @cmoinier ! Looks mostly good to me, just left some comments inline.
Not sure if you've tested it locally, but if you want to do so, you can by:
- setting a remote
geonetwork4_api_url
and uncommentingweb_component_embedder_url = "/datahub/wc-embedder.html"
in thedefault.toml
npx nx docker-build datahub
docker run -p 8082:80 geonetwork/geonetwork-ui-datahub:share-integrate-maps-tables
apps/webcomponents/src/app/components/gn-dataset-view-map/gn-dataset-view-map.component.ts
Show resolved
Hide resolved
libs/feature/record/src/lib/data-view-permalink/data-view-permalink.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/record/src/lib/data-view-web-component/data-view-web-component.component.ts
Outdated
Show resolved
Hide resolved
apps/webcomponents/src/app/components/gn-dataset-view-map/gn-dataset-view-map.component.ts
Show resolved
Hide resolved
libs/feature/record/src/lib/data-view-permalink/data-view-permalink.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cmoinier !
As we discussed one last thing is to not display the share features when no links are present:
... and to comment the bootstrap
as mentioned in line. Otherwise looks good to merge.
c60bdbf
to
5bb338b
Compare
Description
This PR introduces the share and embedding functionalities to the table and map views of the preview. It also adds a new web component for the map view.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
labelThis work is sponsored by MEL.