Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATAHUB]: Record has no link error displayed when loading #947

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[DATAHUB]: Record has no link error displayed when loading #947

merged 3 commits into from
Jul 24, 2024

Conversation

rcaplier
Copy link
Collaborator

@rcaplier rcaplier commented Jul 23, 2024 •
edited
Loading

Description

This PR fix the issue with the error block "This record has no link ..." that would be displayed while the record was still being loaded.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Geocat.

@rcaplier rcaplier self-assigned this Jul 23, 2024
@rcaplier rcaplier added the bug Something isn't working label Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

📷 Screenshots are here!

jahow
jahow approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! please remove the .only before merging :)

@rcaplier rcaplier force-pushed the dh-fix-record-has-no-link-displayed-while-loading branch from cb9ff46 to 0587e8a Compare July 24, 2024 08:37
@coveralls
Copy link

Coverage Status

coverage: 82.903% (-0.7%) from 83.632%
when pulling 0587e8a on dh-fix-record-has-no-link-displayed-while-loading
into 00c93be on main.

@rcaplier rcaplier merged commit 7856573 into main Jul 24, 2024
9 checks passed
@rcaplier rcaplier deleted the dh-fix-record-has-no-link-displayed-while-loading branch July 24, 2024 12:48
@jahow jahow mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees

@rcaplier rcaplier

Labels
backport 2.3.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcaplier @coveralls @jahow