Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: draft rollback #966

Merged
merged 4 commits into from
Aug 27, 2024
Merged

ME: draft rollback #966

merged 4 commits into from
Aug 27, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Aug 22, 2024

Description

This PR introduces the undo functionality on a record with pending changes (draft).

Architectural changes

The form field sub components now all use input and output to follow changes on their field value. This is more explicit, and no less performant than the previous use of FormControl, which was recreated on each value change anyway.

The multiple ngIf in the form-field component have been replaced by a single ngSwitch for clarity.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Affected libs: feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-inputs, ui-layout,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Aug 22, 2024

📷 Screenshots are here!

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/draft-rollback branch 2 times, most recently from 72b087c to 762e1c4 Compare August 26, 2024 14:02
@LHBruneton-C2C
Copy link
Collaborator Author

@LHBruneton-C2C TODO: translation

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very impressive work!! That was a huge refactoring. Looks like the editable label and overview input are much more efficient now. Also this fixed an issue where the overview field would dispatch a "record changed" action as soon as the record was loaded, which was a problem as a record would always be in "draft" mode. And it's good that you took the addOptions out of the sortable list, I think it makes a lot of sense :)

Nothing to add except that there's is no i18n, which you're aware of :) thanks!

@LHBruneton-C2C LHBruneton-C2C merged commit 7a893ad into main Aug 27, 2024
12 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/draft-rollback branch August 27, 2024 14:35
@coveralls
Copy link

Coverage Status

coverage: 81.367% (-1.9%) from 83.248%
when pulling cfaafc5 on ME/draft-rollback
into a6f221e on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants