-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME: draft rollback #966
ME: draft rollback #966
Conversation
3502290
to
cd68125
Compare
Affected libs:
|
📷 Screenshots are here! |
72b087c
to
762e1c4
Compare
@LHBruneton-C2C TODO: translation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, very impressive work!! That was a huge refactoring. Looks like the editable label and overview input are much more efficient now. Also this fixed an issue where the overview field would dispatch a "record changed" action as soon as the record was loaded, which was a problem as a record would always be in "draft" mode. And it's good that you took the addOptions out of the sortable list, I think it makes a lot of sense :)
Nothing to add except that there's is no i18n, which you're aware of :) thanks!
762e1c4
to
bfaf131
Compare
bfaf131
to
cfaafc5
Compare
Description
This PR introduces the undo functionality on a record with pending changes (draft).
Architectural changes
The form field sub components now all use input and output to follow changes on their field value. This is more explicit, and no less performant than the previous use of FormControl, which was recreated on each value change anyway.
The multiple ngIf in the form-field component have been replaced by a single ngSwitch for clarity.
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label