[ME]: Filter out place keywords in keyword section #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyword section of metadata editor, add e2e test for place keywords and other keywords
|
Affected libs:
|
|
📷 Screenshots are here! |
LHBruneton-C2C
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Looking and working great, except the national / regional coverage keyword is displayed in the generic keywords components, and I think it should not be displayed, same as place keywords. I think you can recognize those specifically from the form fields config.
keywords list in the form (visual), but keep all keywords in the record.
Angi-Kinas
commented
Sep 10, 2024
| @@ -175,16 +175,27 @@ export class FormFieldSpatialExtentComponent { | |||
| ...(thesaurus && { thesaurus }), | |||
| } as Keyword) | |||
| ) | |||
| const notPlaceKeywords = await firstValueFrom( | |||
|
|
|||
| const notPlaceKwAndSpatialScopeKw = await firstValueFrom( | |||
There was a problem hiding this comment.
Sorry, I couldn't find a better name...
|
@LHBruneton-C2C I filtered out the national / regional keyword from the keywords list on the editor form (visually), but kept them in the record. |
LHBruneton-C2C
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that place keywords were shown twice in the editor. Once in the spatial extent section and once on the third page in the keyword section.
Now the keywords are visually separated.
Note:
It is still important to save ALL keywords in the record in the "keywords" property.
Quality Assurance Checklist
breaking changelabelbackport <release branch>label