Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: Disable non-implemented buttons #995

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Sep 18, 2024

Description

This PR disables buttons that are not implemented yet. It concerns :

  • Create record from template (import dropdown)
  • Editor top toolbar : open panel / lightbulb / download / question mark / check
  • Dashboard top toolbar : notifications / chat / settings --> Note : for these buttons, ngClass was used to keep the old class (instead of just replacing the current one) and not loose the "normal" styling of the buttons for when this will be reverted.
  • Side Panel : discussion / calendar / contacts / thesaurus / templates --> Note : ngClass was also used to make sure the buttons are not clickable (but hoverable for the tooltip) & to keep the "normal" route for when this will be reverted.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 18, 2024

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 82.189% (-1.6%) from 83.787%
when pulling 0512152 on ME/disable-buttons
into 86d11dd on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmoinier cmoinier merged commit 66a3379 into main Sep 19, 2024
13 checks passed
@cmoinier cmoinier deleted the ME/disable-buttons branch September 19, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants