Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add notebook about working with local files #139

Merged
merged 3 commits into from
May 13, 2020

Conversation

darribas
Copy link
Collaborator

Opening new PR with more notebook content:

  • Local files notebook finished

I think from my side the only bit that'd be needed is to add a notebook for the deep dive on add_basemap but, the more I think about it, the less convinced I am that we need one. All the functionality is covered among the other notebooks (crs, providers and local files). The only value I'd see is to have more examples and all centralised in one notebook for add_basemap, but I'd be inclined to leave this as a good first issue for other contributors to jump on.

What do you think @jorisvandenbossche / @ljwolf ?

@jorisvandenbossche jorisvandenbossche changed the title Notebook writing DOC: add notebook about working with local files Apr 29, 2020
@jorisvandenbossche
Copy link
Member

Looks good!

I can't run the notebook locally (some incompatibility with the rasterio version I have locally, need to figure out my environment), so didn't push anything, but 2 tiny remarks:

  • There are a few occurences of "GeoTIF" that should be "GeoTIFF"
  • For the Polygon creation, using box(west, south, east, north) would be simpler (with from shapely.geometry import box).

@jorisvandenbossche
Copy link
Member

@darribas I think this is fine to get merged? (I just had two minor comments, see above, for the rest a super notebook!)

@darribas
Copy link
Collaborator Author

Just pushed the suggestions, thanks very much!!! Yes, I think it's ready to merge. Thanks very much @jorisvandenbossche for the comments!

@jorisvandenbossche jorisvandenbossche merged commit 97d5f04 into geopandas:master May 13, 2020
@jorisvandenbossche
Copy link
Member

Cool!

jpn-- added a commit to jpn--/contextily that referenced this pull request Jan 8, 2021
…iles

* commit '3c26d5a16a094e8d5ae05f8e5a41f05278816daf':
  DOC: update for latest pydata-sphinx-theme (fix sidebar + use CSS variables) (geopandas#168)
  RLS: v1.0.1
  Fix resetting of extent with local files (geopandas#155) (geopandas#156)
  Add random user ID for Nominatim and allow arbitrary geocoder (geopandas#164)
  Close and reopen memfile dataset before WarpedVRT (geopandas#165)
  Fix use of rasterio MemoryFile (geopandas#163)
  DOC: Use Cape Town consistently in description and variable names (geopandas#154)
  Add matplotlib Framework classifier (geopandas#152)
  Require Python 3.6 as minimum version (geopandas#150)
  Add earthengine to docker for binder
  Example interfacing GEE with contextily (geopandas#147)
  DOC: add notebook about working with local files (geopandas#139)

# Conflicts:
#	tests/test_ctx.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants