DOC: add notebook about working with local files #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
changed the title
|
Looks good! I can't run the notebook locally (some incompatibility with the rasterio version I have locally, need to figure out my environment), so didn't push anything, but 2 tiny remarks:
|
|
@darribas I think this is fine to get merged? (I just had two minor comments, see above, for the rest a super notebook!) |
|
Just pushed the suggestions, thanks very much!!! Yes, I think it's ready to merge. Thanks very much @jorisvandenbossche for the comments! |
|
Cool! |
jpn--
added a commit
to jpn--/contextily
that referenced
this pull request
Jan 8, 2021
…iles * commit '3c26d5a16a094e8d5ae05f8e5a41f05278816daf': DOC: update for latest pydata-sphinx-theme (fix sidebar + use CSS variables) (geopandas#168) RLS: v1.0.1 Fix resetting of extent with local files (geopandas#155) (geopandas#156) Add random user ID for Nominatim and allow arbitrary geocoder (geopandas#164) Close and reopen memfile dataset before WarpedVRT (geopandas#165) Fix use of rasterio MemoryFile (geopandas#163) DOC: Use Cape Town consistently in description and variable names (geopandas#154) Add matplotlib Framework classifier (geopandas#152) Require Python 3.6 as minimum version (geopandas#150) Add earthengine to docker for binder Example interfacing GEE with contextily (geopandas#147) DOC: add notebook about working with local files (geopandas#139) # Conflicts: # tests/test_ctx.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening new PR with more notebook content:
I think from my side the only bit that'd be needed is to add a notebook for the deep dive on
add_basemapbut, the more I think about it, the less convinced I am that we need one. All the functionality is covered among the other notebooks (crs, providers and local files). The only value I'd see is to have more examples and all centralised in one notebook foradd_basemap, but I'd be inclined to leave this as a good first issue for other contributors to jump on.What do you think @jorisvandenbossche / @ljwolf ?