COMPAT: use numpy searchsorted #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is not needed + to overcome pandas API change in 0.24.0 to return scalar instead of 1-element array
|
@darribas This should be ready to be merged as is (no new tests needed, as existing tests already cover it and are passing) |
|
Merging as the error that's picked up relates to #56 and not to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it is not needed + to overcome pandas API change in 0.24.0
to return scalar instead of 1-element array
Noticed when I was running the tests for the other PR using pandas master. Related change in pandas is pandas-dev/pandas#23801