Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix fid_as_index=True doesn't set fid as index read_dataframe with use_arrow=True #265

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Aug 11, 2023

closes #264

@theroggy theroggy changed the title BUG: fid_as_index=True is ignored when using use_arrow=True in read_dataframe BUG: Fix fid_as_index=True doesn't set fid as index read_dataframe with use_arrow=True Aug 11, 2023
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theroggy , glad you caught this. Other than one minor change to tests, this is ready to go.

pyogrio/tests/test_arrow.py Outdated Show resolved Hide resolved
@theroggy theroggy merged commit 5ccdff4 into geopandas:main Aug 14, 2023
16 checks passed
@theroggy theroggy deleted the BUG-fid_as_index=True-is-ignored-when-using-use_arrow=True-in-read_dataframe branch August 14, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: fid_as_index=True doesn't set fid as index read_dataframe with use_arrow=True
2 participants