Raise error if function is used with parameters to read no geometry, columns, or fids #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes and tests to ensure following behaviour for both
use_arrow=True
anduse_arrow=False
:columns=[]
,read_geometry=False
andreturn_fid/fid_as_index=False
, a ValueError is raisedcolumns=[]
,read_geometry=False
andreturn_fid/fid_as_index=True
, the index is read and returnedfid_as_index=False
and the result ends up having no geometry nor attribute columns (eg. because the input file doesn't have a geometry column andcolumns=[]
), an empty DataFrame is returned.closes #263