Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: warn when reading a multilayer file without specifying layer #362

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Feb 24, 2024

resolves #355 , by giving a warning if a multilayer file is being read without specifying the layer to be read.

@theroggy theroggy changed the title Enh warn when reading multilayer file without specifying layer ENH: warn when reading a multilayer file without specifying layer Feb 24, 2024
@theroggy theroggy marked this pull request as ready for review February 25, 2024 08:18
pyogrio/_io.pyx Outdated Show resolved Hide resolved
@brendan-ward brendan-ward added this to the 0.8.0 milestone Feb 28, 2024
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! A few suggestions...

CHANGES.md Outdated Show resolved Hide resolved
pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/_io.pyx Outdated Show resolved Hide resolved
pyogrio/tests/test_arrow.py Outdated Show resolved Hide resolved
pyogrio/_io.pyx Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit dff672c into geopandas:main Mar 11, 2024
19 checks passed
@theroggy theroggy deleted the ENH-warn-when-reading-multilayer-file-without-specifying-layer branch March 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH?: make layer= mandatory if multiple layers in a file?
3 participants