-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: enable more ruff rules + make appropriate changes #415
ENH: enable more ruff rules + make appropriate changes #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup @theroggy , just a few minor comments.
…f-rules-+-make-appropriate-changes
I synced most settings with the recent update in geopandas, including the custom isort config. Additional rules:
Also updated ruff version to 0.5.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @theroggy , this PR is good cleanup. Just a couple minor suggestions from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Same rules as applied in geopandas + pyupgrade (python 3.8) + pydocstyle