Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: enable more ruff rules + make appropriate changes #415

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented May 13, 2024

Same rules as applied in geopandas + pyupgrade (python 3.8) + pydocstyle

@theroggy theroggy marked this pull request as ready for review May 13, 2024 23:11
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @theroggy , just a few minor comments.

pyogrio/core.py Outdated Show resolved Hide resolved
pyogrio/raw.py Outdated Show resolved Hide resolved
pyogrio/util.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyogrio/geopandas.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@theroggy theroggy marked this pull request as draft July 20, 2024 10:46
@theroggy
Copy link
Member Author

theroggy commented Jul 20, 2024

I synced most settings with the recent update in geopandas, including the custom isort config.

Additional rules:

  • pydocstyle
  • target-version = "py38", because project.requires-python = ">=3.8" is in setup.py, not in pyproject.toml
  • [tool.ruff.lint.isort]
    combine-as-imports = true

Also updated ruff version to 0.5.2.

@theroggy theroggy marked this pull request as ready for review July 20, 2024 11:42
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @theroggy , this PR is good cleanup. Just a couple minor suggestions from me.

pyogrio/core.py Outdated Show resolved Hide resolved
pyogrio/raw.py Show resolved Hide resolved
@brendan-ward brendan-ward added this to the 0.10.0 milestone Jul 25, 2024
@theroggy theroggy self-assigned this Aug 10, 2024
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit e2e0a01 into geopandas:main Aug 21, 2024
27 of 28 checks passed
@theroggy theroggy deleted the ENH-enable-more-ruff-rules-+-make-appropriate-changes branch August 21, 2024 12:55
@theroggy theroggy restored the ENH-enable-more-ruff-rules-+-make-appropriate-changes branch August 27, 2024 21:10
@theroggy theroggy deleted the ENH-enable-more-ruff-rules-+-make-appropriate-changes branch August 27, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants