-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD/RLS: Bump MacOS wheels to MacOS 12 (+ bump cibuildwheel from 2.17.0 to 2.18.1) #417
BLD/RLS: Bump MacOS wheels to MacOS 12 (+ bump cibuildwheel from 2.17.0 to 2.18.1) #417
Conversation
Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.17.0 to 2.18.1. - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.17.0...v2.18.1) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
With the latest versions, we get an error in The first commit setting the deployment target at 10.9 gave: |
Once I fixed the issue with having to specify the MACOSX_DEPLOYMENT_TARGET for the latest version of cibuildwheel and delocate, we run into the macOS x86_64 wheel segfaulting on import. I had hoped that this update would have fixed that, but so those crashes are not related to original changes in this PR, since we see the segfaults in #418 as well. The segfaults are probably related to some update on the macOS side (although it is strange this only happens now, given that the latest release in the macOS 11.x series already happened last year). Specifically we see segfaults on macOS 11 with x86_64 (so not with the arm images). Several other projects are observing those segfaults as well, for example duckdb (duckdb/duckdb#12199 (comment), and they updated their python wheels to target 12.0 in duckdb/duckdb#12236), and pyarrow (apache/arrow#41696). MacOS 11 (Big Sur) is no longer officially supported by Apple (although only 3.5 years old ..), and also the github actions So we will have to update the runner on which we build the x86_64 wheels anyway, but so also won't be able to test anymore if the wheels would be working on older macos versions. Many other projects (eg numpy) still release wheels tagged with 10.9 (like we also did up to now), although I don't think anyone tests that this actually works. |
I think given that MacOS 11 is no longer supported by Apple and the segfaults affect other projects within the ecosystem, it seems reasonable for us to bump the minimum supported version to 12, with the expectation that folks on 11 have to build from source (per DuckDB's approach) - rather than providing wheels that may segfault. |
Yeah, with some trial an error, I tried to test whether it would still work if we build on newer macOS but target and test on older, but so that also gave segfaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note to the changelog that wheels are only available for MacOS 12+? Otherwise this is ready to merge. Thanks @jorisvandenbossche !
Bumps pypa/cibuildwheel from 2.17.0 to 2.18.1.
Release notes
Sourced from pypa/cibuildwheel's releases.
Changelog
Sourced from pypa/cibuildwheel's changelog.
Commits
ba8be0d
Bump version: v2.18.190dd476
doc: add documentation for theCIBW_FREE_THREADED_SUPPORT
optionb613249
chore: pass a PythonConfiguration to install_cpython3992d57
feat: add option to opt-in free-threaded builds345467c
feat: add support for free-threaded (no-gil) Python 3.13791e41c
[Bot] Update dependencies (#1832)9d5f5e6
Makecontainer-engine
a build (non-global) option (#1792)1b354cf
chore: move to hatchling (#1297)d1a4c9c
chore: un-pin virtualenv update (#1830)78bca57
fix(tests): linux tests from macOS/Windows arm64 (#1829)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)