BUG: Enable mask & bbox filter when geometry column not read #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
force-pushed
the
geom_mask
branch
2 times, most recently
from
f273b56
to
69ae70e
Compare
brendan-ward
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Good catch @snowman2 ! Can you please add a changelog entry? Assume the next release will be 0.9.1
Sure - just added it. |
brendan-ward
reviewed
Jul 2, 2024
snowman2
force-pushed
the
geom_mask
branch
2 times, most recently
from
b83afbe
to
11bf3fb
Compare
brendan-ward
approved these changes
Jul 2, 2024
|
Thanks @brendan-ward 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, when a
bboxormaskis passed in and the geometry is ignored, the filter excludes all rows and an empty response is returned.