MAINT: change conda dependency to libgdal-core + remove dependency on pyproj #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! |
theroggy
changed the title
theroggy
changed the title
brendan-ward
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Thanks @theroggy ; just a minor comment to make it more explicit that folks need to install pyproj. Please merge once that is in (if you agree with the changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
libgdal-coreas dependency instead oflibgdal. This package is significantly smaller as it doesn't contain some large GDAL plugins. Extra plugins can be installed as seperate conda packages if needed: more info here.This PR also removes the
pyogriodependency onpyproj, aspyprojis not part oflibgdal-corenorgeopandassincegeopandas 1.0: closes #456Reference conda-forge/pyogrio-feedstock#48