Create fixture for test files of other file types

[theroggy]

References #73

[brendan-ward]

Thanks for working on this @theroggy ! A few changes are needed to get this properly working on multiple extensions.

[brendan-ward]

Thanks for continued work on this!

A few minor comments...

[brendan-ward]

combine the best of both worlds

The solution you came up with looks good and addresses my prior concerns over private functions.

create bug issues for these cases

Yes, please!

[theroggy]

combine the best of both worlds

The solution you came up with looks good and addresses my prior concerns over private functions.

create bug issues for these cases

Yes, please!

It turned out that no new bugs needed to be logged:

• One issue was already logged: BUG: GDAL does not raise error for invalid column in where expression for GPKG #4
• Another test failing turned out to be because the fid in GPKG starts at 1 instead of 0, so I changed the test to accomodate for this.
  Do you think it is cleaner to make a set of file types/extensions with 1-based fid instead of zero based?
  Or (not in scope of this pull request), expand on the DRIVERS dict as a dict/class/enum to add these things as properties, e.g.:
  • drivername
  • has_0_based_fid
  • supports_mixed_single_multi (to replace the DRIVERS_NO_MIXED_SINGLE_MULTI dict)
  • supported_write modes? (could reuse the info in _ogr.pyx)
  • ...

[brendan-ward]

expand on the DRIVERS dict as a dict/class/enum

This seems like a good idea, in a separate PR, since there is a growing amount of properties we have to relate back to specific drivers.

[brendan-ward]

Thanks @theroggy !