Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade to actions/checkout@v3, explicitly set git safe dir for release #78

Merged
merged 37 commits into from
Apr 21, 2022

Conversation

brendan-ward
Copy link
Member

The latest version of git that landed in the manylinux image used for Linux wheel build explicitly requires setting the safe directory. Upgrading to actions/checkout@v3 enables this option (default true) and explicitly sets it for the release steps.

@jorisvandenbossche
Copy link
Member

Is it intentional that this targets the other PR's branch?

@jorisvandenbossche
Copy link
Member

This seems to fix it! Maybe update pypa/manylinux#1309 with the solution

Base automatically changed from fix_windows_vcpkg to main April 21, 2022 19:09
@brendan-ward
Copy link
Member Author

Is it intentional that this targets the other PR's branch?

Yes, wanted to build against the other fixes.

@brendan-ward brendan-ward merged commit 58534cd into main Apr 21, 2022
@brendan-ward brendan-ward deleted the try_linux_git_safe_dir branch April 21, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants