Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CAD): snap enabled on edit feature vertices, CAD support for rotated maps #234

Merged
merged 16 commits into from
Aug 10, 2022

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Jul 20, 2022

  • Include edit or draw feature vertices when rendering snap lines in CADControl
  • Add support for CAD when map is rotated

How to

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • IE11 tested.
  • The title is formatted as a conventional-commit message.
  • The title contains WIP: if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

IMPORTANT: Squash commits before or on merge to prevent every small commit being written into the change log. The Pull Request title will be written as message for the new commit containing the squashed commits and there fore needs to be in conventional-commit format

@vercel
Copy link

vercel bot commented Jul 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
openlayers-editor ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 7:11PM (UTC)

@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for openlayers-editor ready!

Name Link
🔨 Latest commit 9dbf0f4
🔍 Latest deploy log https://app.netlify.com/sites/openlayers-editor/deploys/62d972ee61290e0008f3d177
😎 Deploy Preview https://deploy-preview-234--openlayers-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danji90 danji90 changed the title fix(CAD): include edit or draw feature vertices when rendering snap lines in CADControl Draft: fix(CAD): include edit or draw feature vertices when rendering snap lines in CADControl Jul 21, 2022
@danji90 danji90 changed the title Draft: fix(CAD): include edit or draw feature vertices when rendering snap lines in CADControl Draft: fix(CAD): improve CAD control Aug 8, 2022
package.json Show resolved Hide resolved
src/control/cad.js Outdated Show resolved Hide resolved
src/control/draw.js Outdated Show resolved Hide resolved
src/control/cad.js Outdated Show resolved Hide resolved
src/control/cad.js Outdated Show resolved Hide resolved
src/control/cad.js Outdated Show resolved Hide resolved
Copy link
Contributor

@oterral oterral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danji90 danji90 changed the title Draft: fix(CAD): improve CAD control fix(CAD): snap enabled on edit feature vertices, CAD support for rotated maps Aug 10, 2022
@danji90 danji90 self-assigned this Aug 10, 2022
@danji90 danji90 merged commit 0d706af into master Aug 10, 2022
@oterral oterral deleted the daniel/useOwnNodesForSnaplines branch April 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants