Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netzkarte): add FloorSwitcher component #1212

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

fix(netzkarte): add FloorSwitcher component #1212

wants to merge 13 commits into from

Conversation

danji90
Copy link
Contributor

@danji90 danji90 commented Jan 30, 2025

How to

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@danji90 danji90 self-assigned this Jan 30, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:41pm
trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 2:41pm

@danji90 danji90 marked this pull request as draft January 30, 2025 16:24
@danji90 danji90 changed the title fix(Netzkarte): add FloorSwitcher component fix(netzkarte): add FloorSwitcher component Feb 3, 2025
oterral
oterral reviewed Feb 6, 2025
View reviewed changes
src/config/ch.sbb.netzkarte.sandbox/index.js Outdated
name: "ch.sbb.geschosse",
visible: true,
properties: {
hideInLayerTree: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hideInLegend instead of adding a new property

Copy link
Contributor Author

@danji90 danji90 Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we need a new property because hideInLegend also removes the layers from the permalink, so we can't control the levels via search params

oterral
oterral requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@oterral oterral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor changes requested,

src/config/ch.sbb.netzkarte/index.js Outdated Show resolved Hide resolved
@danji90 danji90 added the enhancement New feature or request label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oterral oterral oterral requested changes

@friedjoff friedjoff Awaiting requested review from friedjoff friedjoff is a code owner

Assignees

@danji90 danji90

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danji90 @oterral