This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add scripts to convert diagram geojson to json #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedjoff
suggested changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of x and y coordinate arrays it would be nice to have the following transformed data structure:
x={x1 * 1000}
y={1000 - y1 * 1000 - (1000 - y1 * 1000 - (1000 - y2 * 1000))}
width={x2 * 1000 - x1 * 1000}
height={1000 - y1 * 1000 - (1000 - y2 * 1000)}
Co-Authored-By: friedjoff <friedjoff.trautwein@geops.de>
friedjoff
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edellucien thanks a lot!
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
friedjoff
added a commit
that referenced
this pull request
Mar 16, 2020
* Add scripts to convert diagram geojson to json * Update package.json Co-Authored-By: friedjoff <friedjoff.trautwein@geops.de> * Change automatization script & add 9 first diagrams * Add z field * Add 10, 11, 12th diagrams * Correct forestEcoRegion and add some diagrams * Add geojson for diagram from 15 to 22 * Add last diagram geojson * Create location/ecogram json file with all diagrams * fix ESLint issues * Move files and format using Prettier. * Validate forest ecoregion and altitudinal zones. Co-authored-by: friedjoff <friedjoff.trautwein@geops.de>
friedjoff
pushed a commit
that referenced
this pull request
Mar 16, 2020
# [1.3.0](v1.2.0...v1.3.0) (2020-03-16) ### Bug Fixes * remove duplicate forest ecoregion ([be4a4da](be4a4da)) ### Features * add ecogram data and transformation scripts ([#149](#149)) ([987589f](987589f)) * merge 3 altitudinal zones hochmontan into single zone and extract silver fir area ([177fb24](177fb24)) * return options for locate result ([6d7cdd1](6d7cdd1))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.