Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve facet layout, max 8, sort by count, reset #1068

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

pvgenuchten
Copy link
Contributor

@pvgenuchten pvgenuchten commented Jan 10, 2025

Overview

This improves some aspects on facets display in items html:

  • order by count
  • show first 8 buckets and a button to open more buckets
  • add a reset button to those facets which are applied as filter
  • hide facet if it does not contain buckets
  • fix a bug on duplicate filter add in url

image
v
image

Related Issue / Discussion

resolves #1066

Additional Information

related to #1065

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@@ -33,6 +33,7 @@
import logging
import os
from urllib.parse import urlencode, quote
from operator import itemgetter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize standard imports:

import logging
from operator import itemgetter
import os
from urllib.parse import urlencode, quote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

@tomkralidis tomkralidis added this to the 3.0.0 milestone Jan 13, 2025
@tomkralidis tomkralidis merged commit 3e9cf6f into geopython:master Jan 13, 2025
3 checks passed
@pvgenuchten
Copy link
Contributor Author

Thanx tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ogcapi-records] order facet buckets by count, return/display first 20 (by count)
2 participants