Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pin libxml2 at 2.9.1 #453

Closed

Conversation

tomkralidis
Copy link
Member

Overview

DO NOT MERGE

Test for libxml2 2.9.1 travis pinning. Looks like libxml2 2.9.4 introduces XML validation errors.

Related Issue / Discussion

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@tomkralidis
Copy link
Member Author

cc @kalxas

Looks like is an lxml issue. 3.6.1 works, 3.6.4 breaks.

@tomkralidis
Copy link
Member Author

On second thought, more testing:

  • lxml 3.6.1 && libxml2 2.9.1 passes
  • lxml 3.6.2 && libxml2 2.9.1 passes
  • lxml 3.6.3 && libxml2 2.9.4 FAILS with said validation error
  • lxml 3.6.4 && libxml2 2.9.4 FAILS with said validation error

@tomkralidis tomkralidis mentioned this pull request Aug 24, 2016
8 tasks
@tomkralidis tomkralidis reopened this Sep 26, 2016
@ricardogsilva
Copy link
Member

It would be great if we could bump the version of lxml to 3.6.3 or higher. According to this thread on stackoverflow, and I've also tested it myself on ubuntu 16.04, lxml is now providing wheels (AKA binary downloads) on pypi. This would mean that installing lxml would be a lot faster on Travis (and everywhere else too). It would also mean that installing pycsw would be faster and with fewer external dependencies (no need for libxml2-dev and libxslt1-dev anymore).

@tomkralidis
Copy link
Member Author

cc @kalxas

@ricardogsilva not sure about this one given #454. @kalxas?

@kalxas
Copy link
Member

kalxas commented Dec 22, 2016

We have to make sure that other distributions also have this version available, not just Pypi.

@tomkralidis
Copy link
Member Author

Given #454 it looks like there has not been any releases of libxml2 since this bug was addressed?

@ricardogsilva
Copy link
Member

@tomkralidis @kalxas
FYI, libxml2 has a new release out, version 2.9.5. Perhaps this will fixes the long standing validation issues?

@kalxas
Copy link
Member

kalxas commented Sep 21, 2017

we have to test :)

@tomkralidis
Copy link
Member Author

Closing. Looks like deploys are using recent libxml2 builds.

@tomkralidis tomkralidis deleted the travis-libxml2-2.9.1 branch September 25, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants