Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CSW service / version support (optional in 3.0.0) (#544) #552

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

tomkralidis
Copy link
Member

Overview

In CSW 3, service and version parameters are optional (required in CSW 2.0.2). This PR does deeper detection of CSW 2 vs. 3 requests and handles/sets service and version accordingly.

Related Issue / Discussion

#544

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #552 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   55.93%   55.98%   +0.05%     
==========================================
  Files          29       29              
  Lines        6338     6346       +8     
  Branches     1342     1345       +3     
==========================================
+ Hits         3545     3553       +8     
  Misses       2412     2412              
  Partials      381      381
Flag Coverage Δ
#integrationtests 54.63% <100%> (+0.05%) ⬆️
#unittests 7.62% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pycsw/server.py 65.58% <100%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4edd7...58886dd. Read the comment docs.

@tomkralidis tomkralidis merged commit a98cbd7 into geopython:master Nov 9, 2017
@tomkralidis tomkralidis deleted the issue-544 branch November 9, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant