Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetches records for map display as ajax #949

Conversation

pvgenuchten
Copy link
Contributor

Overview

The PR suggests to fetch records as ajax for loading on map, instead of rendering geojson inline

Related Issue / Discussion

#948

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@tomkralidis
Copy link
Member

Thanks @pvgenuchten. I guess the question here is weighing 2 HTTP requests vs 1 (with a bigger response length because of the data inline in JavaScript). Adding @kalxas and @ricardogsilva for any comments.

@pvgenuchten
Copy link
Contributor Author

pvgenuchten commented Feb 1, 2024

Correct, indeed good to make an analysis of pro's and con's.

  • Having 2 requests creates a larger total (and more cpu), but for each of the individual responses they will be smaller.

Other direction here could be to dump only bbox, id & title in the html, not the full features dict

@pvgenuchten
Copy link
Contributor Author

closing this for limited interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants