#102 several fixes for (dead) links in navigating HTML #103
Conversation
| @@ -166,3 +166,7 @@ def serve(ctx, debug=False): | |||
| # setup_logger(CONFIG['logging']) | |||
| APP.run(debug=True, host=api_.config['server']['bind']['host'], | |||
| port=api_.config['server']['bind']['port']) | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': # run locally, for testing | |||
There was a problem hiding this comment.
Do we need this? pygeoapi serve accomplishes this already.
There was a problem hiding this comment.
Main reason for main() here is for (stepwise) debugging within an IDE like IntelliJ IDEA or WebStorm and probably PyCharm: needed easy entry point.
pygeoapi/api.py
Outdated
| @@ -125,6 +125,10 @@ def root(self, headers, args): | |||
| ] | |||
|
|
|||
| if format_ == 'html': # render | |||
| for link in fcm['links']: | |||
| if 'json' in link['type']: | |||
| link['href'] += '?f=json' | |||
There was a problem hiding this comment.
is this better written as link['href'] = ''.join((link['href'], '?f=json'))? I'm not sure what the current verdict is around 'adding' strings in Python.
There was a problem hiding this comment.
From what I read both + and join can be used, with join being marginally faster with many strings to concatenate. For readablity + is preferred.
|
Checks failed since one test need change in |
|
Also needed to fix the breadcrumbs relative URL paths: in cases where the page URL ends with Now all HTML links are based on Flask/Werkzeug Also needed to rewrite the |
Appears this issue was not really due to #92.
At least no dead links anymore and JSON content when accessed in browser.
Question remains that on single Item the
NextandPrevlinks should really walk through Collection but I suggest to do that in other issue, as this is quite tricky to achieve (as one does not know the prev/next id's in isolation of single Item).Hold on..one failing test now...