Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dataset specific templates (#1857) #1858

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

tomkralidis
Copy link
Member

Overview

Adds support for dataset specific templates.

Related Issue / discussion

Fixes #1857

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis added enhancement New feature or request ui User interface labels Nov 20, 2024
@tomkralidis tomkralidis added this to the 0.19.0 milestone Nov 20, 2024
@tomkralidis tomkralidis changed the title support dataset specific tenplates (#1857) support dataset specific templates (#1857) Nov 20, 2024
Copy link
Member

@webb-ben webb-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

One thing that remains a bit opaque in the documentation (and without a tangible example) is what is required in the content of a dataset specific template.

Is this template able to inherit the header and footer in _base.html? Or does it require a full HTML template?

@tomkralidis
Copy link
Member Author

This all looks good to me.

One thing that remains a bit opaque in the documentation (and without a tangible example) is what is required in the content of a dataset specific template.

It is expected that a developer adding a custom template would review an existing default template to better understand the scope of the UI functionality for a given HTML render.

Is this template able to inherit the header and footer in _base.html? Or does it require a full HTML template?

This is at the developer's discretion (similar to custom templates at any level).

Having said this, I've added some additional info to the docs.

@tomkralidis tomkralidis merged commit a795620 into geopython:master Dec 8, 2024
5 checks passed
@tomkralidis tomkralidis deleted the dataset-templates branch December 8, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support dataset specific templates
2 participants