Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic to support v2 #1941

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

francbartoli
Copy link
Contributor

Overview

Related Issue / discussion

See:

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@webb-ben
Copy link
Member

webb-ben commented Feb 24, 2025

Support general housekeep but seems like this PR should just include the changes made in pygeoapi/models/config.py, pygeoapi/models/openapi.py, requirements-django.txt, and requirements.txt.

Note: because we are using Ubuntu Noble for the Dockerfile, it might be worth coming to a quorum about what version of Ubuntu pygeoapi is supporting. If we want to be in line with RFC2, wouldn't we want to downgrade the Dockerfile base image? If we want to keep it on Jammy, I would also recommend including python3-pydantic in ADD_DEB_PACKAGES

@tomkralidis
Copy link
Member

Pending discussion in #1766

@kalxas
Copy link
Member

kalxas commented Mar 4, 2025

CI fails.
@francbartoli can you please rebase only the core pydantic commit (0a03614) to master?

@francbartoli francbartoli force-pushed the feature/pydantic-v2 branch from 2c0b8e3 to ea3c2c3 Compare March 4, 2025 22:25
@kalxas
Copy link
Member

kalxas commented Mar 4, 2025

Thanks for fixing CI.

Copy link
Member

@kalxas kalxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not squash when merging. I would like to keep the core pydantic 2 commit in git history

@francbartoli
Copy link
Contributor Author

Should I merge or wait for another approval?

@tomkralidis
Copy link
Member

Given we are releasing 0.20.0, I would prefer to merge this immediately after 0.20.0 is released (at which point we will create a 0.20 branch).

@tomkralidis tomkralidis added this to the 0.21.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants