-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pydantic to support v2 #1941
base: master
Are you sure you want to change the base?
Conversation
3400993
to
0a03614
Compare
Support general housekeep but seems like this PR should just include the changes made in Note: because we are using Ubuntu Noble for the Dockerfile, it might be worth coming to a quorum about what version of Ubuntu pygeoapi is supporting. If we want to be in line with RFC2, wouldn't we want to downgrade the Dockerfile base image? If we want to keep it on Jammy, I would also recommend including |
Pending discussion in #1766 |
CI fails. |
2c0b8e3
to
ea3c2c3
Compare
Thanks for fixing CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not squash when merging. I would like to keep the core pydantic 2 commit in git history
Should I merge or wait for another approval? |
Given we are releasing 0.20.0, I would prefer to merge this immediately after 0.20.0 is released (at which point we will create a 0.20 branch). |
Overview
Related Issue / discussion
See:
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)