Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the django framework #630

Merged
merged 17 commits into from
Aug 27, 2022

Conversation

francbartoli
Copy link
Contributor

@francbartoli francbartoli commented Feb 17, 2021

Implement #586

Pending tasks:

  • Rebase with master
  • Add support for Django 3 and 4
  • Align the current endpoints in the Django application
  • Fix the statics for the HTML pages
  • Make sure the Django application is pluggable when the pygeoapi package is installed
  • Add documentation

@francbartoli francbartoli self-assigned this Feb 17, 2021
@francbartoli francbartoli added the in progress Assigned person(s) are working on issue label Feb 17, 2021
@kalxas
Copy link
Member

kalxas commented Feb 18, 2021

Is pygeoapi/db.sqlite3 needed or can it be created by the ORM?

kalxas
kalxas approved these changes Feb 18, 2021
@webb-ben
Copy link
Member

webb-ben commented Jul 1, 2021

@ksonda and I were talking about a use case for pygeoapi in which there is an admin interface (for those who prefers GUI over CLI). I know Flask has importable packages, but this comes already integrated in Django.

With that in mind, I was wondering what is the status of this PR? Are you at all taking contributions? Are there any suggestions for us?

@francbartoli
Copy link
Contributor Author

Hi @webb-ben and @ksonda and thanks for looking into this.

The purpose of this PR is to add the option to start a Django server in the pygeoapi cli https://github.com/geopython/pygeoapi/pull/630/files#diff-1696c76ab8f15157943cb6d039faf97ab95c21958691ced33c6491bf03344770R45-R62.

If I understand well the admin interface you are proposing is something available before starting the server right?
How do you imagine the flow?

@tomkralidis
Copy link
Member

@francbartoli any update on this one? Should we close the PR for now (but keep #586 open)?

@francbartoli
Copy link
Contributor Author

@tomkralidis it isn't a high priority feature for now but the PR is already flagged as a draft. Anyway it is fine with me if we want to close at the moment

@lucadelu
Copy link
Contributor

lucadelu commented Mar 4, 2022

Any news about Django support? it could be really useful, what was missing in the @francbartoli implementation?

@francbartoli
Copy link
Contributor Author

Any news about Django support? it could be really useful, what was missing in the @francbartoli implementation?

Thanks for looking into this @lucadelu, concretely the module was not quite ready as django application for being installed and used within GeoNode

@lucadelu
Copy link
Contributor

lucadelu commented Mar 4, 2022

ok maybe for GeoNode is not yet ready but it could be useful to have it for normal user as me. I'm implementing a REST API using django and I was thinking to serve also OGCAPI standard using pygeoapi, the code seems to be useful.

I could help a little bit to test or improve it if you think it could be merge in the main code (I need sometime since I'm completely new to pyogcapi)

@francbartoli
Copy link
Contributor Author

Thanks @lucadelu, it would be helpful if you can contribute. It has been stalled now for a while and it's likely the work needs to be aligned with all the new endpoints added to pygeoapi. But yeah we can work together to progressively complete this feature

@lucadelu
Copy link
Contributor

lucadelu commented Mar 4, 2022

Yes please, could you please create a TODO list of features needed before the merge, and I also need a little bit of help to set the working environment. Could we plan a discussion during the next week code sprint?

@francbartoli
Copy link
Contributor Author

Yes please, could you please create a TODO list of features needed before the merge, and I also need a little bit of help to set the working environment. Could we plan a discussion during the next week code sprint?

Sure! That's a very good idea, I was thinking the same 👍

@francbartoli
Copy link
Contributor Author

@lucadelu I've added a tasks list at the top. Let's catch up during the sprint

@lucadelu
Copy link
Contributor

lucadelu commented Mar 5, 2022

@lucadelu I've added a tasks list at the top. Let's catch up during the sprint

@francbartoli could be possible to update to newer Django release (now it seems required Django < 3)

Do you have any preferred time during the sprint?

@francbartoli
Copy link
Contributor Author

I’ve added the new item for version 3. Let’s organize the time during the days. Have you already joined the OGC Discord server? What’s your handle over there?

@msmitherdc
Copy link
Collaborator

Django 4 is the current release. You should target current

@lucadelu
Copy link
Contributor

lucadelu commented Mar 5, 2022

I’ve added the new item for version 3. Let’s organize the time during the days. Have you already joined the OGC Discord server? What’s your handle over there?

Yes I joined, my username is lucadelu

@francbartoli francbartoli marked this pull request as ready for review August 27, 2022 15:57
@francbartoli francbartoli merged commit 98bfdd5 into geopython:master Aug 27, 2022
@francbartoli francbartoli removed the in progress Assigned person(s) are working on issue label Aug 27, 2022
@tomkralidis
Copy link
Member

Great work everyone!

@lucadelu @krishnaglodha can each of you, in this PR, add a contributor agreement comment with the following (raw Markdown below):

# Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

- [ ] I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
- [ ] I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Thanks

@tomkralidis tomkralidis mentioned this pull request Aug 28, 2022
2 tasks
@tomkralidis
Copy link
Member

Luca's agreement put forth in #971 (comment)

@tomkralidis
Copy link
Member

Krishna's agreement put forth in #971 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants