add back pygeoif 1.0.0 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like test failures are similar to issues related to https://github.com/geopython/pygeofilter/actions/runs/3756959066/jobs/6383625611#step:8:40 |
|
@tomkralidis so it seems the issue is here https://github.com/geopython/pygeofilter/blob/main/pygeofilter/backends/sqlalchemy/__init__.py we are trying to import |
Merged
|
fixed in #65 |
tomkralidis
force-pushed
the
pygeoif-1.0.0
branch
from
1e49eb4 to
c4615d5
Compare
tomkralidis
force-pushed
the
pygeoif-1.0.0
branch
from
457db91 to
a6a20dc
Compare
|
are we ready for the release? cc @constantinius |
constantinius
approved these changes
Jan 9, 2023
|
@constantinius thanks for merging the PR 🙏 Is there any blockers for an official release with this fix? |
|
thanks for releasing 0.2.1 ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase/reapply of #56
cc @drnextgis @constantinius @landryb