Skip to content

Conversation

@wadackel
Copy link
Contributor

Hi @georapbox, Thank you for Good Libraries 👍

ImmutableDelete does not seem to behave as expected when deleting an element with index 0.

const arr = ['a', 'b', 'c', 'd', 'e'];
const res = immutableDelete(arr, 0);

console.log(res);
// Result: ['a', 'b', 'c', 'd', 'e']
// Expected: ['b', 'c', 'd', 'e' ]

This PR fixes these bugs.
Thanks.

Copy link
Owner

@georapbox georapbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @tsuyoshiwada!
Thanks for contributing!

@georapbox georapbox merged commit f8cc419 into georapbox:master Jun 24, 2017
@wadackel
Copy link
Contributor Author

@georapbox Thanks you for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants