CSW fix #274
Merged
CSW fix #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch query. Fixes #7527
…earch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries
…earch query / Escape Elasticsearch special chars in IS LIKE literal queries
jeanmi151
approved these changes
Jan 10, 2024
f-necas
added a commit
that referenced
this pull request
Jan 10, 2024
* Revert #253 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query. Fixes #7527 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in IS LIKE literal queries * Reset geotools usage and comments tests --------- Co-authored-by: Jose García <josegar74@gmail.com>
f-necas
added a commit
that referenced
this pull request
Jan 25, 2024
* Revert #253 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query. Fixes #7527 * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in EQUAL / NOT EQUAL literal queries * CSW GetRecords doesn't escape query values when creating the Elasticsearch query / Escape Elasticsearch special chars in IS LIKE literal queries * Reset geotools usage and comments tests --------- Co-authored-by: Jose García <josegar74@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSW Fix
Fixes two errors :
Original pending PR :
geonetwork/core-geonetwork#7529
Some tests are actually not working but REST requests passes.
To discuss :
Migrate to geotools 30 to stick with upstream. Could be done after upstream PR is merged
Issue impacted :