Rabbitmq - Fix event sending process #81
Conversation
marwanehcine
force-pushed
the
fix_rabbitmq_event_sending_process_for_gateway
branch
from
068bab3 to
e8e798c
Compare
There was a problem hiding this comment.
The GHA is failing:
https://github.com/georchestra/georchestra-gateway/pull/81/checks
so I wouldd expect the PR is not ready for review yet
gateway/src/test/java/org/georchestra/gateway/rabbitmq/SendMessageRabbitmqIT.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @SpringBootTest(classes = GeorchestraGatewayApplication.class) | ||
| @TestPropertySource(properties = { // | ||
| "georchestra.datadir=${user.dir}/src/test/resources/data_directory" }) |
There was a problem hiding this comment.
It does not sound to me as very portable, it doesn't resolve on my dev environment.
| return interfaceAddress.getAddress().getHostAddress(); | ||
| } | ||
| } catch (SocketException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
I'd make use of a logger, even in a test context.
This needs this PR to be merged before to make compilation works : |
marwanehcine
force-pushed
the
fix_rabbitmq_event_sending_process_for_gateway
branch
5 times, most recently
from
cdaa9cb to
2c3cb9c
Compare
pmauduit
changed the title
pmauduit
changed the title
I am still concerned by the failing testsuite though. |
marwanehcine
force-pushed
the
fix_rabbitmq_event_sending_process_for_gateway
branch
2 times, most recently
from
09e927f to
255feae
Compare
marwanehcine
force-pushed
the
fix_rabbitmq_event_sending_process_for_gateway
branch
from
255feae to
8de54bb
Compare
1- fix rabbitmq event sending process after code refactor
2- adding IT test for communication between gateway and console using rabbitmq