Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current issues with forecasting #1283

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Fix current issues with forecasting #1283

merged 11 commits into from
Oct 19, 2023

Conversation

americast
Copy link
Member

@americast americast commented Oct 13, 2023

This PR aims to solve the following issues:

Will create separate PRs for the last two points.

@americast americast marked this pull request as draft October 13, 2023 06:57
@americast americast added this to the v0.3.8 milestone Oct 13, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Oct 13, 2023

Hi @americast

  1. We can have separate PRs instead of one PR for everything.
  2. For non-numeric characters are in the data, it is not only a problem for forecasting, for example, classification/predictions may also suffer this data cleaning problem. I think the alternative approach is to provide a REGEX function for generic uses instead of forecast only.

Let me know what you think. You don't need to worry about the REGEX function, and can look into forecast-specific issue more.

@americast
Copy link
Member Author

americast commented Oct 13, 2023

Sure. Will create separate PRs for pt 4 & 5. Keeping this single PR for the three short changes as mentioned in pts 1, 2 and 3.

@americast americast marked this pull request as ready for review October 14, 2023 09:16
@americast
Copy link
Member Author

@xzdandy Resolved all the concerns

@xzdandy
Copy link
Collaborator

xzdandy commented Oct 19, 2023

I am fixing the Doc.

Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the tutorial notebook to showcase these two features.

@americast
Copy link
Member Author

I will update the tutorial notebook to showcase these two features.

Thanks a lot @xzdandy! Let me know once you are done with that add I will add some more comparisons to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Enhance forecasting with more features
3 participants