Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified that issue #1067 is resolved and added documentation for load pdf functionality. #1343

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

kslohith
Copy link
Contributor

@kslohith kslohith commented Nov 7, 2023

Issue #1067 about not being able to load pdf files, was verified to be working with evadb documentation pdf and a new page for loading pdf is added to the documentation.
Screenshot 2023-11-07 at 1 33 01 AM

@jarulraj
Copy link
Member

jarulraj commented Nov 7, 2023

@kslohith Right now, if we load a corrupted pdf, what is the behavior?

@jarulraj
Copy link
Member

jarulraj commented Nov 7, 2023

I have added a partial unit test here (not fully written) -- https://github.com/georgia-tech-db/evadb/tree/kslohith-staging

@jarulraj jarulraj merged commit 7a49bec into georgia-tech-db:staging Nov 7, 2023
6 of 8 checks passed
@kslohith
Copy link
Contributor Author

kslohith commented Nov 8, 2023

@jarulraj I tried to load a corrupted pdf file, it was successfully loaded into evadb, giving this response.
0 0 Number of loaded PDF: 1
But when i try to query the table, the response is empty, i think nothing was inserted.
We should modify this behaviour and give a error message when the upload itself was a corrupted pdf instead of giving a success message.
Let me know if i should take this up and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants