feat: Predicate Pushdown across join and Fix Materialization Bugs #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statement_binder_context.py
This was referenced Aug 13, 2022
jarulraj
reviewed
Aug 14, 2022
| @@ -217,7 +256,8 @@ def create_sample_video_as_blob(num_frames=NUM_FRAMES): | |||
|
|
|||
| def copy_sample_videos_to_upload_dir(): | |||
| shutil.copyfile( | |||
| "data/ua_detrac/ua_detrac.mp4", os.path.join(UPLOAD_DIR, "ua_detrac.mp4") | |||
| "data/ua_detrac/ua_detrac.mp4", | |||
There was a problem hiding this comment.
Will these hard-coded paths work on Windows?
There was a problem hiding this comment.
They might not. I’ll fix these. Looks like we have a lot of instances in the this file. Can be done in a separate PR.
jarulraj
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.