-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: postgres integration - create database #932
Conversation
gaurav274
commented
Aug 15, 2023
•
edited
Loading
edited
- Add support for creating database
- Persist the info in the catalog
- Todo: Verify if the provided info is valid - next PR
evadb/server/command_handler.py
Outdated
# For certain statements, we plan to omit binder and optimizer to keep the code | ||
# clean. So, we handle such cases here and pass the statement directly to the | ||
# executor. | ||
if stmt not in SKIP_BINDER_AND_OPTIMIZER_STATEMENTS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. To make it clear, the default engine (for now, sqlite3) in evadb/catalog/sql_config.py will not have an entry in DatabaseCatalog (otherwise, we have a loop. Maybe we can actually, so it is not treated differently with any other databases created later by the user).
|
The |
Will document it in our design docs |