Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto drop row id for CREATE UDF xxx FROM ( SELECT * FROM ...) ... #943

Merged
merged 11 commits into from
Aug 24, 2023
Merged

Auto drop row id for CREATE UDF xxx FROM ( SELECT * FROM ...) ... #943

merged 11 commits into from
Aug 24, 2023

Conversation

xzdandy
Copy link
Collaborator

@xzdandy xzdandy commented Aug 22, 2023

👋 Thanks for submitting a Pull Request to EvaDB!

🙌 We want to make contributing to EvaDB as easy and transparent as possible. Here are a few tips to get you started:

  • 🔍 Search existing EvaDB PRs to see if a similar PR already exists.
  • 🔗 Link this PR to a EvaDB issue to help us understand what bug fix or feature is being implemented.
  • 📈 Provide before and after profiling results to help us quantify the improvement your PR provides (if applicable).

👉 Please see our ✅ Contributing Guide for more details.

@xzdandy xzdandy changed the title Auto drop row id for CREATE UDF xxx FROM ( SELECT * FROM ...) ... Auto drop row id for CREATE UDF xxx FROM ( SELECT * FROM ...) ... Aug 24, 2023
jiashenC
jiashenC approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jiashenC jiashenC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiashenC
jiashenC reviewed Aug 24, 2023
View reviewed changes
evadb/binder/binder_utils.py
target_list: List[AbstractExpression],
) -> List[AbstractExpression]:
"""
This function is intended to be used by CREATE UDF FROM (SELECT * FROM ...) and CREATE TABLE AS SELECT * FROM ... to exclude the row_id column.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CREATE TABLE AS SELECT * FROM ... also covered in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not covered in this PR. This PR only contains the support for Model training.

@xzdandy xzdandy merged commit 39f7071 into master Aug 24, 2023
@xzdandy xzdandy deleted the select_star_drop_row_id_for_train branch August 24, 2023 22:20
@gaurav274 gaurav274 added the Bug 🐞 EVA is not working as expected label Aug 25, 2023
@gaurav274 gaurav274 added this to the v0.3.2 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiashenC jiashenC jiashenC approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees

@xzdandy xzdandy

Labels
Bug 🐞 EVA is not working as expected
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xzdandy @jiashenC @gaurav274