Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pgtype with pgx/v5/pgtype #97

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

vadimi
Copy link
Contributor

@vadimi vadimi commented Oct 7, 2022

It looks like in pgx v5 github.com/jackc/pgtype package needs to be replaced with github.com/jackc/pgx/v5/pgtype

https://github.com/jackc/pgx/blob/f803c790d0999e9028cbffefad9df02e4aff913a/CHANGELOG.md#merged-packages

as mentioned by @kohenkatz in PR #94

@vadimi
Copy link
Contributor Author

vadimi commented Oct 7, 2022

@georgysavva I also feel like some of the docs in in doc.go don't make much sense in v2 of the package, especially around custom types

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #97 (a5421a1) into master (3003c11) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   82.81%   82.74%   -0.07%     
==========================================
  Files           5        5              
  Lines         512      510       -2     
==========================================
- Hits          424      422       -2     
  Misses         73       73              
  Partials       15       15              
Flag Coverage Δ
unittests 82.74% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pgxscan/pgxscan.go 70.00% <ø> (-0.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@georgysavva
Copy link
Owner

@vadimi Thanks for this PR!

@georgysavva I also feel like some of the docs in in doc.go don't make much sense in v2 of the package, especially around custom types

I fixed the pgxscan docs part regarding pgtype. Did I get it right? What else do you find irrelevant for the v2 package?

@vadimi
Copy link
Contributor Author

vadimi commented Oct 8, 2022

@georgysavva this is great, thank you

@georgysavva georgysavva merged commit 0203330 into georgysavva:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants